[DragonFlyBSD - Bug #3075] (New) sys/bus/u4b/wlan/if_upgt.c: 3 * pointless tests ?

bugtracker-admin at leaf.dragonflybsd.org bugtracker-admin at leaf.dragonflybsd.org
Wed Oct 11 01:47:09 PDT 2017


Issue #3075 has been reported by dcb.

----------------------------------------
Bug #3075: sys/bus/u4b/wlan/if_upgt.c: 3 * pointless tests ?
http://bugs.dragonflybsd.org/issues/3075

* Author: dcb
* Status: New
* Priority: Low
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
dragonfly/sys/bus/u4b/wlan/if_upgt.c:1225]: (style) Unsigned variable 'channel' can't be negative so it is unnecessary to test it.

Source code is

       if (!(channel >= 0 && channel < IEEE80211_CHAN_MAX))

but

    unsigned channel;


Some duplicates:

dragonfly/sys/bus/u4b/wlan/if_upgt.c:1258]: (style) Unsigned variable 'channel' can't be negative so it is unnecessary to test it.
dragonfly/sys/bus/u4b/wlan/if_upgt.c:1286]: (style) Unsigned variable 'channel' can't be negative so it is unnecessary to test it.




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account



More information about the Bugs mailing list