[DragonFlyBSD - Bug #2993] sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?

bugtracker-admin at leaf.dragonflybsd.org bugtracker-admin at leaf.dragonflybsd.org
Tue Mar 28 12:54:46 PDT 2017


Issue #2993 has been updated by dillon.


This bug exists in FreeBSD too it seems.  I don't know the correct logic right-offhand.

-Matt

----------------------------------------
Bug #2993: sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
http://bugs.dragonflybsd.org/issues/2993#change-13093

* Author: dcb
* Status: New
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
sys/dev/raid/mfi/mfi_tbolt.c:1159]: (warning) Logical disjunction always evaluates to true: EXPR != 40 || EXPR != 42.

Source code is

    if (cdb[0] != 0x28 || cdb[0] != 0x2A) {

Maybe better code

    if (cdb[0] != 0x28 && cdb[0] != 0x2A) {




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account


More information about the Bugs mailing list