[issue1140] installkernel POSTFIX directive

YONETANI Tomokazu qhwt+dfly at les.ath.cx
Mon Sep 22 22:12:32 PDT 2008


On Mon, Sep 22, 2008 at 08:48:16AM -0700, Matthew Dillon wrote:
>     I think its important for DESTLABEL to not need the '.', though it
>     does mean some additional complication in the Makefile's.  I recommend
>     building an internal DESTKERNNAME and DESTMODULESNAME based on
>     DESTLABEL.  If DESTLABEL does not exist DESTKERNNAME would be 'kernel'
>     and DESTMODULESNAME would be 'modules'.  If DESTLABEL does exist then
>     DESTKERNNAME would be 'kernel.${DESTLABEL}' and DESTMODULESNAME would
>     be 'modules.${DESTLABEL}'.
> 
>     One could also override the whole name by specifying DESTKERNNAME and
>     DESTMODULESNAME.

DESTMODULESNAME is functionally similar to KMODDIR.  Unfortunately the
default value of KMODDIR is defined in bsd.own.mk and only used by
kmod.mk and not by kern.post.mk.  So, currently, if you set KMODDIR to
somewhere other than /boot/modules, modules-install still populates
/boot/modules.old with stripped version of modules in /boot/modules,
not with the ones in $KMODDIR.
The reason kern.post.mk does not care about the default value of KMODDIR
is because the Makefile in kernel build directory does not include
bsd.own.mk, which defines KMODDIR.  I have no idea that bsd.own.mk should
not be included by bsd.post.mk or the Makefile in the kernel build directory.

Cheers.





More information about the Bugs mailing list