Is buildworld broken?

[Joerg Sonnenberger]

On Sat, Mar 19, 2005 at 11:04:26AM -0500, Adrian Nida wrote:
> I'm trying to rebuild world, kernel, etc. and ran into this error.  I rm'ed -r /
> usr/obj, rm'ed -r /usr/src, and re-cvsupped (as of ~30 minutes ago).  Is anyone 
> else seeing this?  If not, any ideas what I should do to fix?

What's going on is that getopt_long.c as compiled by the bootstrap
part of patch wants to use the optarg variables from libc. That's
perfectly fine for the normal libc, but when compiled with the
-DREPLACE_GETOPT version of libc as used by that short time frame,
those variables are defined in the libc version of getopt_long.c.
This results in the name space clash, since both getopt_long.c from
libc and the version directly compiled into patch want to define
getopt_long.

An easy way to work around it is to define REPLACE_GETOPT for patch
and the other users of libc's getopt_long as part of the build stage.

I'll keep this in mind when working later on it again.

Joerg