ServeRAID driver: kmem_slab_alloc: bad flags

YONETANI Tomokazu qhwt+dragonfly-bugs at les.ath.cx
Fri Jul 9 00:19:10 PDT 2004


Hello.
I got a panic in ips_add_waiting_command() while checking out the source
tree with cvsup on an X335 with ServeRAID4Lx. This is because ips driver
was not completely adjusted to work with the recent changes to M_* flags
(0 is not a correct kernel malloc flag). If I read the code correctly,
the only caller of ips_add_waiting_command() is ips_get_free_cmd(), and
ips_add_waiting_command() will never be called with flags set to
IPS_NOWAIT_FLAG because of the conditional immediately before the call.
So I removed `flags' from the arguments of ips_add_waiting_command() and
hard-code M_INTWAIT there.
With modified driver, cvsup completed without a problem, and I'm running a
make -j16 buildworld now.

Attached patch should fix two things:
- the panic
- broken RCS keywords

I also found a few style bugs, but I left them untouched for now.
Attachment:
ips-mini-fix.diff.gz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bin00000.bin
Type: application/octet-stream
Size: 1113 bytes
Desc: "Description: application/gunzip"
URL: <http://lists.dragonflybsd.org/pipermail/bugs/attachments/20040709/24a78dc0/attachment-0016.bin>


More information about the Bugs mailing list